Closed urbanite-municipalist closed 10 months ago
For the two enums
pub enum Block { Header(Vec<Span>, usize), Paragraph(Vec<Span>), Blockquote(Vec<Block>), CodeBlock(Option<String>, String), OrderedList(Vec<ListItem>, OrderedListType), UnorderedList(Vec<ListItem>), Raw(String), Hr, }
pub enum Span { Break, Text(String), Code(String), Link(String, String, Option<String>), Image(String, String, Option<String>), Emphasis(Vec<Span>), Strong(Vec<Span>), }
There are several variants, which are unnecessarily unclear. Could Block::CodeBlock, Span::Link, Span::Image, be replaced by field variants? Or could the separate components be documented?
https://docs.rs/markdown/0.3.0/src/markdown/parser/mod.rs.html#31-40 https://docs.rs/markdown/0.3.0/src/markdown/parser/mod.rs.html#10-20
Just writing what #[allow(missing_docs)] is allowing to be missing in these two cases.
Thank you.
You use an unmaintained version of this crate. The crate changed owners. Use this project, not the old one.
For the two enums
There are several variants, which are unnecessarily unclear. Could Block::CodeBlock, Span::Link, Span::Image, be replaced by field variants? Or could the separate components be documented?
https://docs.rs/markdown/0.3.0/src/markdown/parser/mod.rs.html#31-40 https://docs.rs/markdown/0.3.0/src/markdown/parser/mod.rs.html#10-20
Just writing what #[allow(missing_docs)] is allowing to be missing in these two cases.
Thank you.