search

wooorm / refractor

Lightweight, robust, elegant virtual syntax highlighting using Prism
MIT License
724 stars 34 forks source link

Incorrect global in jsdom environment #38

Closed rexxars closed 3 years ago

rexxars commented 3 years ago

After #37 was merged I appear to have some issues where prismjs thinks the global is one thing, while refractor thinks it's a different thing. This results in Prism.manual not being set, which makes prism attach events to the DOMReady events and such.

I'm not quite sure what the right solution is - I'll see if I can come up with a reproducible test case.

wooorm commented 3 years ago

Hmm annoying, sorry, thanks for investigating!

/cc @xiaoxiangmoe on this

xiaoxiangmoe commented 3 years ago

@rexxars Can you give me a minimal demo of this?

wooorm commented 3 years ago

Friendly ping @rexxars!

wooorm commented 3 years ago

Closing this for now as not actionable. If this is still an issue and can be solved here, I’d appreciate a reproduction!