woorea / openstack-java-sdk

OpenStack Java SDK
Apache License 2.0
194 stars 198 forks source link

Customized executor for RESTEasyConnector #194

Closed dominikholler closed 7 years ago

dominikholler commented 7 years ago

The RESTEasyConnector is modified to enables the usage of a customized executor for the request. Please find an example how to use a customized executor in QuantumListNetworksTimeout.java

simon3z commented 7 years ago

@dominikholler do you really need to expose the ClientRequest to the subclasses?

If in QuantumListNetworksTimeout.java you just need to provide a different ClientExecutor couldn't you just have exposed a protected ClientExecutor createClientExecutor() method to customize the executor (and keep the part related to ClientRequest as is)?

dominikholler commented 7 years ago

@simon3z thanks for your time and your idea. I implemented your idea in the patch. Please find an updated example in QuantumListNetworksTimeout.java

simon3z commented 7 years ago

LGTM :+1: cc @woorea (in case you want to review)

woorea commented 7 years ago

+1