search

woorea / openstack-java-sdk

OpenStack Java SDK
Apache License 2.0
194 stars 198 forks source link

RESTEasyConnector: Isolate the creation of ClientExecutor #195

Closed dominikholler closed 7 years ago

dominikholler commented 7 years ago

The creation of the ClientExecutor is isolated in a protected method, to allow subclasses to overwrite.

This enables the usage of a customized executor for the request. The customized executor is needed to set parameters, like timeouts, on the creation of the executor.

(cherry picked from commit 23922741ab80dc665f83362fbc7b14e8af0240a3)

simon3z commented 7 years ago

I think this is important enough to be in the 3.1.x branch :+1:

@dominikholler @woorea this looks backward compatible to me, please keep me honest on this.

dominikholler commented 7 years ago

I am not aware how this change could break backward compatibility.