woorea / openstack-java-sdk

OpenStack Java SDK
Apache License 2.0
194 stars 198 forks source link

Openstack error messages are not propagated to user #201

Open mmirecki opened 6 years ago

mmirecki commented 6 years ago

Error messages form Openstack are not passed on to the caller. Inside ApacheHttpClient4Executor (resteasy) in the execute method where we do the http request, we do not look at the contents of the output (so we loose the message), but return only the ErrorCode. The problem could be solved by overriding the executor and setting the error message on the response.

The code: https://github.com/resteasy/Resteasy/blob/e9374dfbb58abcb93ca546f7b8a94ab966c062c9/resteasy-legacy/src/main/java/org/jboss/resteasy/client/core/executors/ApacheHttpClient4Executor.java#L285 The missing error message: response.setErrorMessage(IOUtils.toString(res.getEntity().getContent()));

The problem should preferably be solved in resteasy, and woorea should be updated to use the version with the fix. If moving to the latest resteasy is not possible, woorea should provider its own improved Executor.