search

wootguy / Glitch-Life

Randomizes Sven Co-op maps
http://forums.svencoop.com/showthread.php/42021-Glitch-Life-program
36 stars 8 forks source link

Sound replacement crash #17

Closed wootguy closed 5 years ago

wootguy commented 5 years ago

https://github.com/wootguy/Glitch-Life/blob/26806484a32856654b27d88653951e1e6c22f2eb/src/sound_util.cpp#L788

bad bounds checking there or something. Thanks to DarrenV for reporting.

Edit: More possible buffer overruns:

Severity    Code    Description    Project    File    Line    Suppression State
Warning    C6385    Reading invalid data from 'monsters':  the readable size is '116' bytes, but '-4' bytes may be read.    gsrand    D:\CODE\GLITCH-LIFE\SRC\SOUND_UTIL.CPP    456    
Warning    C6385    Reading invalid data from 'mdirs':  the readable size is '1160' bytes, but '-40' bytes may be read.    gsrand    D:\CODE\GLITCH-LIFE\SRC\SOUND_UTIL.CPP    459    
Warning    C6385    Reading invalid data from 'msize':  the readable size is '116' bytes, but '-4' bytes may be read.    gsrand    D:\CODE\GLITCH-LIFE\SRC\SOUND_UTIL.CPP    463    
Warning    C6385    Reading invalid data from 'mlists':  the readable size is '232' bytes, but '-8' bytes may be read.    gsrand    D:\CODE\GLITCH-LIFE\SRC\SOUND_UTIL.CPP    466    
Warning    C6386    Buffer overrun while writing to 'monsters':  the writable size is '116' bytes, but '-4' bytes might be written.    gsrand    D:\CODE\GLITCH-LIFE\SRC\SOUND_UTIL.CPP    480