wootguy / bspguy

Tool for editing GoldSrc maps without decompiling
The Unlicense
129 stars 30 forks source link

Bad Normal For Plane Errors #89

Closed ToxicHolyGrenade closed 6 months ago

ToxicHolyGrenade commented 2 years ago

The story with this error is that whilst I am editing the Hopelessness 2 maps in order to crossover content from Half-Life: Absolute Zero, occasionally BSPGuy causes plane errors on the map I've edited, which caused the game to automatically disconnect, and when I try to type in the same map with this issue, it crashes the whole game.

What's going on?

wootguy commented 2 years ago

No idea. I'd need the unedited bsp file and steps to reproduce the error.

ToxicHolyGrenade commented 2 years ago

Here is this unedited BSP file to use as an example.

------ Original Message ------ From: "wootguy" @.> To: "wootguy/bspguy" @.> Cc: "ToxicHolyGrenade" @.>; "Author" @.> Sent: Tuesday, 19 Apr, 22 At 13:02 Subject: Re: [wootguy/bspguy] Bad Normal For Plane Errors (Issue #89)

No idea. I'd need the unedited bsp file and steps to reproduce the error. — Reply to this email directly, view it on GitHub https://github.com/wootguy/bspguy/issues/89#issuecomment-1102555872 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATZKNGKXH43W52RVWXFXEWLVF2OGNANCNFSM5TYRPBOA . You are receiving this because you authored the thread.Message ID: @.***>

ToxicHolyGrenade commented 2 years ago

Keep in mind, this problem occasionally happens, not all the time.

wootguy commented 2 years ago

Creating/editing/deleting BSP models and using the clean/optimize command might be corrupting the BSP. Changes that can be done with ripent should be safe.

ToxicHolyGrenade commented 2 years ago

What do you mean by BSP models, you mean NPC models?

Plus, it's the same with le2b from Life's End, and the Bad Normal For Plane errors are happening there too. But to be entirely honest, this has never happened to me before on BSPGuy version 3. I've edited monster_generic (the Kingpin and the Archers), , as well as changing some of the leeches to Archers, and that's about it, and I don't see how that is to affect the map. New WinRAR ZIP archive.zip

wootguy commented 2 years ago

Changing entity settings is "safe" and shouldn't affect plane data. There's a chance v4 fixes the problem but I still don't know how to reproduce this. That le2b map is loading fine for me in Sven Co-op.

What do you mean by BSP models, you mean NPC models?

Models that stored in the BSP file. They're used for entities like doors, elevators, and trigger areas.

ToxicHolyGrenade commented 2 years ago

I'm sorry, but as it turns out, le20 of Life's End, has the same errors, and this time its just the monstermakers I have edited. There is something definitely wrong.

To be honest, I am using XASH FWGS, and I don't remember this happening on regular XASH.

wootguy commented 2 years ago

Let me know if you figure out how to trigger the error. The map still loads for me after randomly editing keyvalues on the monstermakers.

ToxicHolyGrenade commented 2 years ago

Keep in mind, this is happening on XASH FWGS, not Sven Co-op. All I did, was edit one of the monstermakers that produce the Alien Slaves to Floaters, and the error just happens out of nowhere when I try to enter the map. And it crashes the whole game.

The worst part is, this "bad normal for plane" error has not been documented; there is nothing on how to fix this error and how to prevent it from occurring.

wootguy commented 2 years ago

I tried the same map in the latest Xash3D i386 build, and it still loads. Maybe the type of edit you did is important? Maybe a bug in the Xash version you're using? I could try your edited bsp and see if it still works.

ToxicHolyGrenade commented 2 years ago

New WinRAR ZIP archive.zip

wootguy commented 2 years ago

That map loads for me. I needed to add a spawnpoint before Xash would let me do map le20 though. I made the edit using bspguy v3. le20_wootguy_edit.zip

ToxicHolyGrenade commented 2 years ago

Strange, it works. I think it has something to do with a coding bug in version 4 that's causing this. I hope version 5 is more polished, and with this bug getting finally fixed at that stage.

ToxicHolyGrenade commented 2 years ago

Okay, to update you on the issue, it might not be something to with BSPGuy after all, it has something to do with the XASH 3D FWGS engine. I tried the original XASH 3D engine, loaded map le20 that supposedly has the bad normal for plane errors, and it works.

wootguy commented 2 years ago

I can at least add a validation check for bad plane normals. If all of the normals are fine in the BSP then it probably is a Xash bug. Though it's still possible bspguy corrupted the bsp in such a way that only a specific version of Xash noticed.

ToxicHolyGrenade commented 2 years ago

What about the likes of BSPGuy Master? Does it need it too?

wootguy commented 2 years ago

yes, probably