woothee / woothee-php

Woothee PHP implementation
110 stars 13 forks source link

Static API #28

Open zonuexe opened 9 years ago

zonuexe commented 9 years ago

refs #25

I understand that instance is useful for SoC. But other implements (including Java) do not provided API for classifier instance. I think it is not to bring confusion to the user be provide static and dynamic API. What do you think? @tagomoris

@yuya-takeyama written https://github.com/woothee/woothee-php/pull/25#issuecomment-156799536:

Doesn't it cause any issue to call static methods in object context?

No problem. fb5b2e6981711562cfa29a374ed6046bce2c6269 can revert.

yuya-takeyama commented 9 years ago

I can understand your point (consistency between languages). But IMO, it's not a matter. Implementations should follow its languages's manner.

However, I can also understand the benefit of static method for its handiness to call.

My concerns are below.

@woothee/woothee-php-team Any thoughts?