search

worace / geoq

Geospatial Utility Belt
MIT License
71 stars 8 forks source link

Fix warnings, switch to 2018 edition #35

Closed stanislav-tkach closed 4 years ago

stanislav-tkach commented 4 years ago

Fixes #33.

worace commented 4 years ago

@DarkEld3r this is awesome! Thanks so much for finding this issue and taking it on. I should have gotten around to it for a while but obviously never found the time.

By the way I notice several of the files got reformatted in a way that looks like it might have come from an automated formatter. Could you share what tool you are using for that? I might like to incorporate it into my workflow as well so things will continue to match.

stanislav-tkach commented 4 years ago

I have only used rustfmt: it can sort import now. As for the nested imports (such as use std::{fs::File, io::BufReader}) it is just a mater of my preference, though rustfmt can format them too.

If you like to enable formatting check on the CI, it can be easily done with the cargo fmt -- --check command. By the way, rustfmt is now included in the default package if Rust is installed using rustup.

worace commented 4 years ago

I see that makes sense; I have rustfmt integrated through my editor but probably I was just using an older version of it or something that didn't match exactly. Thanks again.