search

wordplaydev / wordplay

An accessible, language-inclusive programming language and IDE for creating interactive typography on the web.
Other
63 stars 44 forks source link

Arrow keys to modify numeric text fields #176

Closed amyjko closed 9 months ago

amyjko commented 1 year ago

What's the problem?

There are many text fields in the palette that represent numbers (e.g., offset or place on Phrase). Editing them by typing is a bit slow and error prone (changing 9 to 10 requires deleting 10 then typing 9).

What's the idea?

Handle arrow up and down within the text field to increment and decrement numeric values, for quick adjustments. The example above would be achieved by just pressing the down arrow to decrement 10 to 9.

Who benefits?

Anyone using the palette to tweak a design.

Design ideas

I think simple keyboard shortcuts on the field for up and down would suffice.

wkxdavid commented 11 months ago

@amyjko Unless I am misunderstanding the issue, I believe the ability to use arrow key navigability for numeric values is working as its in a arrow key navigability slider. Can I get clarification on this?

amyjko commented 11 months ago

@wkxdavid This issue refers to text fields, not sliders. I updated the description with a more concrete example of this.

shiinasugioka commented 11 months ago

Pull request

amyjko commented 11 months ago

Hi @shiinasugioka and @wkxdavid! Please address the pull request feedback on this issue (including citing this issue in a commit with the text "Fixed #176" so that they are linked.

shiinasugioka commented 10 months ago

Hi Amy! I'm going to remove myself from this issue and leave notes for the next person to take a look at. If anyone working on this issue has any questions, feel free to message me on discord (@ Shiina#3331 )

amyjko commented 10 months ago

@shiinasugioka, you're not going to finish this pull request then? @wkxdavid, are you going to finish it? If not, you should unassign yourself from the pull request as well, so everyone knows that you're not going to finish it.

shiinasugioka commented 10 months ago

@amyjko Actually, sorry I will finish it. I misread the PR comments and thought I had to redo a lot more than I actually had to. I’m not signed up for Wordplay so I thought this would be a good starter issue for a new dev, but looks like I just commit a bunch of file changes that I shouldn’t have. I can get it fixed by the end of the week and I’ll update my PR!

amyjko commented 10 months ago

Thanks @shiinasugioka. Let me know if you have any questions; I'll review your revised PR when it's ready.