leahjia
commented
1 year ago I attempted to add a space indicator mode in en-US.json since that is where I saw all other settings being listed, but it shows a warning saying it's not allowed.
Some notes & suggestions from @amyjko:
en-US.json is the English locale file; it contains strings that are used to localize the interface, not settings.
To make a space toggling setting, there are a number of design considerations:
-
Should it be something that's persistent between sessions?
-
If persisted, should it be editor, project, device, or creator-specific?
-
Should it be an on/off setting, or also allow for customization of the symbols used to indicate space? (And why is this customization necessary)?
-
If off, how can the creator distinguish between explicit spaces in a source file, and pseduo spaces inserted by the editor to preserve layout?
Those are all key design questions to answer before you start on an implementation, because the implementation would change depending on their answers. Design first, then build.
amyjko
momoko0719
lpjjj1222
What's the problem?
The editor always shows spaces and tabs as indicators of where spacing is. One creator became confused by these, since the space indicator was the same as the product indicator, but a different color. They requested the ability to turn off the space indicators.
What's the design idea?
Just have an editor toggle that turns off spacing indicators. This could be synced as a setting in the cloud, or local to an editor, or local to a project. I think the best design is probably an account feature, since its a work preference.
Who benefits?
Any signed user editing code.
Design specification Draft
Here is the second draft of the design specification, please give me feedback and let me know if you have any questions! Thanks!
Functionality
Implement a simple toggle in the creator's settings. This toggle should enable users to turn on or off the spacing indicators according to their preference.
Ensure that the toggle is clearly labeled (e.g., "Show Space Indicators") and accessible, considering creators with different abilities, including those who rely on screen readers.
How the Setting is stored
When a creator modifies this setting, it should be automatically synced to their account in the cloud. This ensures that their preferences are maintained across different devices and sessions.
In addition to cloud syncing, the setting should also be stored locally. This is beneficial in scenarios where the user might be working offline or in a limited connectivity environment.
Persistence Across Sessions:
Auto-Sync on Login: Ensure that when a user logs out and then logs back in, the settings should keep the same.
Local Fallback: In case of connectivity issues, the editor should be able to fall back to the locally stored settings to ensure continuity in the user experience.
Design Considerations
The toggle should be easily accessible but not intrusive. It can be placed in the settings menu where creators can quickly access it without disrupting their workflow.
Provide immediate visual feedback when the setting is toggled. If a user disables the space indicators, the change should reflect instantly in the editor.
Design Drafts
Figma design draft