Open Marc0Guo opened 7 months ago
I noticed the error was in main zh-cn-tutorial line 4103 and 4104. I will try to fix it.
Thanks @Marc0Guo! Remember, when you claim an issue, assign yourself, so others no you're working on it. I look forward to the PR.
I will do that!
Could I work this issue with u
@Kwang37, I assume you're asking @Marc0Guo? (It helps to tag people directly; GitHub can be configured to only do notifications for when you're tagged, so @Marc0Guo might not see this without tagging).
Could I work this issue with u
@Kwang37 Sure.
@Marc0Guo why is this closed? If the issue is resolved, then it should be a pull request to merge into main. If its no longer an issue, you should explain why you closed it here.
@amyjko I'm sorry I made a mistake here. There was still something wrong with the code so I cannot make a pull request. I will fix it as soon as possible.
Let me know how I can help. (Also, the proper way to close an issue, per the wiki, is to include "fixed #nnn" in a commit message, so we know which commit resolved the issue).
The problem is probably due to the zh-CN locale is outdated, Ben is going to update it tonight. If the problem still exist, I will fix it.
It's the end of Winter! Please provide an update on this issue, including:
If you do plan to continue work on it, carry on. Otherwise, thank you for your contributions!
No reply :( Unassigning @Marc0Guo.
The problem exists because of rebasing error. The code for the lines was missing somehow in zn-ch but appears in main. Ben was trying to do rebasing at the end of last quarter but there was a lot of error. Looks like the rebasing is done right now. I found the error code starting from line 4167 in zn-ch, I will fix it this week. ('m going to be volunteering this quarter.)
Thanks @Marc0Guo. Reassigning you, if you're working on this.
The problem was fixed by someone else as I did git pull today on line 4170 to 4172 in "chinese simplified" branch.
Looks like there are still traditional and simplified Chinese mixed together. I am working on it.
@Marc0Guo Are you still working on this?
@yishiz2 When I checked the code, the translation was corrected in both zn-ch and main branch.
@Marc0Guo Sorry I was working on another issue and did not see this, but that is interesting... I am still seeing this on my end.
@yishiz2 I believe the branch on the website is different than the one you are currently working. The issue will be fixed as the current working zn-ch branch is merged to the website branch.
Expected behavior
As I choose Simplified Chinese Mode, I expected all the characters are simplified chinese, but there's traditional chinese characters.
Actual behavior
There are Traditional Chinese Character in Simplified Chinese mode on the welcome page starting from "双关语“. The above paragraph are consist of all Traditional Chinese Characters "無論您的能力如何,都可以透過世界語言中的動畫單字、表情符號和符號來學習編碼。 Wordplay 是一種創新的程式語言 🖥︎️,具有區塊和文字編輯 📝︎、時間 🕦︎、聲音 🎤︎、網頁 🔗︎ 和物理 🌎︎ 等有趣的輸入、即時時間旅行調試 ⏪︎ 以及全面的文檔 🗂︎️。 所有這些都在不斷增長的世界語言清單中🌐︎,遵循最新的網路可訪問性標準♿︎️。 與朋友、私人團體或全世界分享↗︎️。 永遠免費來自"
Screenshots
Environment
What platform, OS, browser, and version are you using? Please be exact with version numbers, as different versions can result in a defect happening or not. Don't skip these; cross-browser issues are a common cause of problems.
Desktop