search

wordplaydev / wordplay

An accessible, language-inclusive programming language and IDE for creating interactive typography on the web.
Other
55 stars 19 forks source link

Pinch to zoom is backwards #426

Open amyjko opened 3 months ago

amyjko commented 3 months ago

Expected behavior

On stage, when pinching out, zoom in; when pinching in, zoom out.

Actual behavior

A student reported that it was the reverse. I didn't have a chance to see it happen, so this should be reproduced.

Environment

The student was using a touch screen Windows PC laptop.

khai2931 commented 15 hours ago

@amyjko I would be interested in resolving this issue as a starting point as a new developer! Here is my proposed plan:

  1. Verify the issue can be reproduced
  2. If can be reproduced, ask Amy or others who know the code well about which files are relevant for this issue (Otherwise, close the issue)
  3. Try to fix the issue in my own fork/branch
  4. Once the issue is resolved, draft a PR and request review
  5. Once approved, finalize the PR
amyjko commented 15 hours ago

Assigned!

The relevant file is OutputView.svelte and the pinching is handled in handlePointerDown, handlePointerMove, and handlePointerUp.

khai2931 commented 14 hours ago

Tested on iPhone 11; pinching behaves correctly as expected. Awaiting testing on touchscreen Windows laptop.

khai2931 commented 14 hours ago

Tested on touchscreen Windows laptop; pinching seems to be working as expected. If anyone has further context for reproduction steps, please comment!

According to Amy, it may be possible to inspect the implementation code and derive repro steps from there.