wordplaydev / wordplay

An accessible, language-inclusive programming language and IDE for creating interactive typography on the web.
Other
55 stars 19 forks source link

Adding hex code to color selector in palette. #443

Open lasyasr opened 2 months ago

lasyasr commented 2 months ago

What's the problem?

Add a text box that will allow the user to add a specific hex code instead of finding the specific hue from the selectors. They would find this in the Color selector palette from the stage. This could be for customization for people who want to have a more personal experience with Wordplay. The users of Wordplay (students, and teachers showing a demo) would be the target audience. In the current design, there are preset colors you can choose, and there are sliders, however, there is no way to add a specific hex code.

What's the design idea?

@amyjko @joonpiter Hello, I have updated my design proposal based on comments from last week!

image

image

Design specification

Reporters can leave this blank. Designers should write a detailed, precise description of what is to be built. If images are necessary to convey this precisely, make sure to include image descriptions, so everyone can see what is in the image. Do not link to external documents; everything should be embedded here. Once the design is approved, we will remove the needs design tag and replace it with the buildable tag, signalling that it can be built.

amyjko commented 2 months ago

@lasyasr Let us know how we can help with this design work!

amyjko commented 2 months ago

While you're working on this, note that the primary color format we use is LCH. (See the documentation for the Color type). Including hex, or RGB, or other color formats, needs to be done carefully, since LCH is the preferred format. See more about LCH here:

https://atmos.style/blog/lch-color-space

lasyasr commented 2 months ago

@amyjko I have created a design idea for changing the look of the color palette on stage. The idea was to allow the users to personalize the text with a color of their choice, and people who see colors differently, usually have a preferred color code. It was not possible to type in a custom code for the color, and there was no way of seeing what the name for each preset color was. Screenshot 2024-04-24 184739 The first image shows what the current design looks like. The second image shows the updated design and changes to meet the needs of the user with accessibility in mind.

amyjko commented 2 months ago

Hi @lasyasr! It sounds like you're asking for design review, correct? If so, here are some points of feedback:

amyjko commented 2 months ago

Thanks for the update @lasyasr. As I understand it, you're proposing to add three text fields to allow LCH values to be edited textually, and one additional text field for hex colors. If I understand that correctly, I have a few questions:

joonpiter commented 1 month ago

@lasyasr, I can't review it because you haven't included the design specification in the issue or the comments. Please add this, and I will review it.

joonpiter commented 1 month ago

HI @lasyasr thanks for clarifying where the design specification is at here my review with that context:

lasyasr commented 1 month ago

Overall this ticket was to support people who have a color preference with a hex code, something that is very familiar and popular when defining a color code. Still need to complete design that includes storing the color based off of what the user provided, and specifying certain interaction patterns. I will not continue to work on this issue.

amyjko commented 1 month ago

@lasyasr, can you clarify your role? Are you continuing work on this?

lasyasr commented 1 month ago

I just updated my earlier comment, I will not be working on this issue anymore.