search

wordplaydev / wordplay

An accessible, language-inclusive programming language and IDE for creating interactive typography on the web.
Other
55 stars 16 forks source link

370 Resizing Stage #473

Open cdong03 opened 1 month ago

cdong03 commented 1 month ago

We implemented resizing the project tiles by dragging with a mouse. This resizing is based on setting the styles directly instead of changing the layout object. When I tried changing the layout object, even inside handlePointerUp(), resizing stopped working.

Implemented:

Notes:

cdong03 commented 1 month ago

Fixed bugs and completed implementation

amyjko commented 1 month ago

@cdong03, are you ready for review? (Explicitly ask for review if you are).

cdong03 commented 1 month ago

Yes, it's ready for review. How do I ask for one?

Sincerely, Caroline Dong

On Tue, May 28, 2024 at 8:58 AM Amy J. Ko @.***> wrote:

@cdong03 https://urldefense.com/v3/__https://github.com/cdong03__;!!K-Hz7m0Vt54!kNTSm0uL_p_6nceEJwPf1H3dQo4bWdDGAelcH-aD9A8vm12uFBHDgtqlbWaP7HyVuuq1c7At7BiIis9BFL7BN_7k$, are you ready for review? (Explicitly ask for review if you are).

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/wordplaydev/wordplay/pull/473*issuecomment-2135604003__;Iw!!K-Hz7m0Vt54!kNTSm0uL_p_6nceEJwPf1H3dQo4bWdDGAelcH-aD9A8vm12uFBHDgtqlbWaP7HyVuuq1c7At7BiIis9BFOxriZjV$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV3A6JGPU67HGM3ORYE5CDDZESSS3AVCNFSM6AAAAABIA5SJM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVGYYDIMBQGM__;!!K-Hz7m0Vt54!kNTSm0uL_p_6nceEJwPf1H3dQo4bWdDGAelcH-aD9A8vm12uFBHDgtqlbWaP7HyVuuq1c7At7BiIis9BFIqxFFFj$ . You are receiving this because you were mentioned.Message ID: @.***>

amyjko commented 1 month ago

You choose a reviewer, or tag the person you wan to review, or say "This is ready for review". (Look for the "Request" in the "Reviewers" section. But it sounds like you're asking me for review :)

cdong03 commented 1 month ago

I see, thank you, professor. Could you please review this?

amyjko commented 1 month ago

@cdong03 indicated that this PR is a draft, and that they will not be finishing it. It is available for someone else to review, refine, and finish. Converted to draft.

amyjko commented 4 weeks ago

@EnclaveGeneral I see you're assigned to this PR. Are you still working on this?