332 resolve duplicate name - Githubissues

wordplaydev / wordplay

An accessible, language-inclusive programming language and IDE for creating interactive typography on the web.

Other

55 stars 16 forks source link

332 resolve duplicate name #477

Closed euouae682 closed 1 month ago

euouae682 commented 1 month ago

Issue: There is no conflict resolution for the DuplicateName conflict (if a declaration ha a duplicate name).

We implemented a resolution button for the duplicate name conflict based on the design specification. Specifically, we did the following:

Allow the user to remove one of the duplicate names with a button if the duplicate names are on the same line
Edited representation of the conflict in NodeTexts.ts and locales to include a resolution message
Display the resolution message next to the button

Some notes:

The resolution only appears if the duplicate names are on the same line; the user must manually resolve the conflict if there are duplicate names on separate lines.

euouae682 commented 1 month ago

Thanks for the pointers! I've implemented the changes, and it should be ready to merge now!