Open amyjko opened 1 year ago
Hi, overall this change looks good and doesn't break and of the accessibility standards were aiming for. Amy has to give the final approval, but I like this change
I think I need to clarify this issue: this was not about improving the visual design of speech bubbles (though that's a fine proposal to make). This was about letting Phrase
output to have speech bubbles on stage. Imagine the letter 'a' having a conversation with the letter 'b' on stage.
If you want to propose this visual redesign of speech bubbles, open a new enhancement issue and propose that. This issue should remain about the extension of Phrase
to include speech bubble support.
(Process hint for the future: always ask questions about an issue before doing a design: you want to make sure you understand the issue before designing for it, especially old issues like this one that are vague).
Initially, I thought this ticket was to re-design the speech bubbles in which the Stage characters use to talk to each other, however after clarification, it was to design for ex "A" to talk to "B" on the stage platform. Need to still finalize a design an output for these speech bubbles within stage.
@lasyasr, can you clarify whether you're continuing work on this issue? You're still assigned, which implies yes, but please unassign yourself if you are not.
I will not be continuing to work on this issue. I will unassign myself from the issue.
Allow phrases to have speech, showing a speech bubble, making it easy to do dialog and storytelling. Speech would be laid out with the phrase. This would just be another property on a phrase or group.
Design Idea: @amyjko @Joonpiter