search

wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
673 stars 114 forks source link

[Docs] Remove Supports Android Info from `README.md` #1030

Closed ParaskP7 closed 1 year ago

ParaskP7 commented 1 year ago

Fixes #1029

With this change the Supports Android 4.1+ (API 16 - Jelly Bean) information is removed from the README.md documentation as this information has been outdated for years now and it has the ability to become outdated with every year passing by. Users of this library should refer to the minSdkVersion within the root level build.gradle file to understand what's the latest min SDK version this library supports.

fluiddot commented 1 year ago

Users of this library should refer to the minSdkVersion within the root level build.gradle file to understand what's the latest min SDK version this library supports.

@ParaskP7 I'm wondering if we should add a note in the README about this, i.e. mention the build.gradle file to check the latest min SDK version this library supports. WDYT?

ParaskP7 commented 1 year ago

👋 @fluiddot !

@ParaskP7 I'm wondering if we should add a note in the README about this, i.e. mention the build.gradle file to check the latest min SDK version this library supports. WDYT?

Yea, that's not a bad idea, why not! 👍

Do you have a suggestion/recommendation of how to do this, that is, it teams of how you are envisioning this to be shown in our README.md. I can go ahead and make this change, but maybe you have something specific on your mind? 🤔

PS: Also, please feel free to make this change yourself and push a change here.

ParaskP7 commented 1 year ago

👋 @fluiddot !

I don't have a strong opinion on whether to keep a note or remove it, so it's ok to me going with this change.

Thank you so much for the suggestion, I too don't have a strong opinion on whether to keep or remove a note on minSdkVersion, but since we are at it, let me add your suggestion and merge this PR afterwards. 🙇

ParaskP7 commented 1 year ago

Thank you so much for the suggestion, I too don't have a strong opinion on whether to keep or remove a note on minSdkVersion, but since we are at it, let me add your suggestion and merge this PR afterwards. 🙇

FYI: @fluiddot this is now done. 7ef5cad1269bf685c1e61a691e14203a191ef2c5

fluiddot commented 1 year ago

Thank you so much for the suggestion, I too don't have a strong opinion on whether to keep or remove a note on minSdkVersion, but since we are at it, let me add your suggestion and merge this PR afterwards. 🙇

FYI: @fluiddot this is now done. 7ef5cad

Great, thank you @ParaskP7 for updating the documentation 🙇 !