Closed irfano closed 1 year ago
👋🏻 @khaykov! Can I know your comment about a feature you updated recently? You just commented and uncommented, but maybe you can still help.
WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE
was deprecated. I want to update it in the recommended way as below.
This constant was deprecated in API level 30. Call Window#setDecorFitsSystemWindows(boolean) with false and install an OnApplyWindowInsetsListener on your root content view that fits insets of type [Type#ime()](https://developer.android.com/reference/android/view/WindowInsets.Type#ime()).
I want to test its effect to be sure it still works as expected, but I couldn't find what this line does exactly. It should resize the block editor position on the screen when the keyboard is shown up, so I removed this line and also removed windowSoftInputMode
on AndroidManifest
but couldn't see any behavior difference.
Do you know how I can test what this line does?
Hey @irfano ! I remember that one :) I was testing updating compileSdk
to see if it will fix an issue we had with Samsung devices (it didn't), and that line gave me some compile-time trouble, so I commented it out locally. It made it's way into the commit by accident so I just reverted it back. Sorry, I can't really help you with the setSoftInputMode
, since I'm not familiar with block editor logic at all :)
Hey @irfano ! I remember that one :) I was testing updating
compileSdk
to see if it will fix an issue we had with Samsung devices (it didn't), and that line gave me some compile-time trouble, so I commented it out locally. It made it's way into the commit by accident so I just reverted it back. Sorry, I can't really help you with thesetSoftInputMode
, since I'm not familiar with block editor logic at all :)
Thank you @khaykov! I found out its function and explained it in the "Test" section.
Fix
This updates
compileSdk
to 33 and makes the required changes.getExternalStoragePublicDirectory()
warning was suppressed and opened an issue. It's a low-priority task since it's on the sample activity.LayoutParams.SOFT_INPUT_ADJUST_RESIZE
was deprecated in API level 30. I suppressed it at first but then found a way to resolve it.Test
Being able to build and basic smoke test should be enough. Updating
LayoutParams.SOFT_INPUT_ADJUST_RESIZE
may be worth a special test. To test:Review
@ParaskP7
Make sure strings will be translated:
strings.xml
as a part of the integration PR.