wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
673 stars 114 forks source link

[Build] Enable Non-Transitive Resources #1050

Closed ParaskP7 closed 10 months ago

ParaskP7 commented 10 months ago

This PR is a prerequisite for the Gradle 8.1.1 & AGP 8.0.2 Upgrade for WPAndroid, WCAndroid & Related Libs project.

Platform Request: pdnsEh-13V-p2 Project Thread: paaHJt-57Z-p2


This PR enables non-transitive resources (android.nonTransitiveRClass) for the project.

FYI: This behavior becomes the default in AGP 8.0 and higher. As such, this becomes a prerequisite for the AGP 8.0.2 upgrade, that is of course, unless android.nonTransitiveRClass is explicitly set to false.


Dependency Versions Refactor List:

  1. Extract automattic publish to s3 version to settings build gradle

To test:

  1. Verify that all the CI checks are successful.
  2. Smoke test the app.

Review

@oguzkocer


Make sure strings will be translated:

ParaskP7 commented 10 months ago

Thank you for reviewing and testing this @oguzkocer , you rock! 🙇 ❤️ 🚀