Improve Mark formatting

geriux commented 3 months ago

Related PRs:

This PR adds missing implementation for the Mark formatting style.

Adds a new MarkPlugin that will handle adding the needed CSS attributes.
Updates the MarkSpan to receive a color param and to set it as the current color.
Removes applyMarkInlineStyle in favor of applyAfterMarkInlineStyle which will handle if the color changes while editing a Mark span.

Test

Please follow the testing instructions in this PR's description.

This shouldn't affect other Aztec functionalities.

Make sure strings will be translated:

[ ] If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

geriux commented 1 month ago

Hey there @antonis 👋

I was wondering if you would be able to help me out with a PR review 😄, I've updated the Highlight color implementation so it fixes some issues for this feature since we first partially implemented it in https://github.com/wordpress-mobile/AztecEditor-Android/pull/943

A lot of testing has been already done in https://github.com/WordPress/gutenberg/pull/57650 so I was wondering if you'd have some time to check the native code for the Aztec side. Let me know if you could take a look! Thank you!

antonis commented 1 month ago

I was wondering if you'd have some time to check the native code for the Aztec side. Let me know if you could take a look! Thank you!

I'll be glad to help with this @geriux :) I plan to get to this later today or tomorrow 🙇

geriux commented 1 month ago

I'll be glad to help with this @geriux :) I plan to get to this later today or tomorrow 🙇

Thank you so much!

geriux commented 1 month ago

Thank you for all of the suggestions @antonis! I've applied them in https://github.com/wordpress-mobile/AztecEditor-Android/pull/1073/commits/17946f2be64e3177a4d1c52d98e53ac79985a1b2 and https://github.com/wordpress-mobile/AztecEditor-Android/pull/1073/commits/2f735642025c364e5a6003505f40d1ee93159237 🚀

wordpress-mobile / AztecEditor-Android

Improve Mark formatting #1073

Test