wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
700 stars 115 forks source link

Improve Mark formatting #1073

Closed geriux closed 8 months ago

geriux commented 10 months ago

Related PRs:

This PR adds missing implementation for the Mark formatting style.

Test

Please follow the testing instructions in this PR's description.

This shouldn't affect other Aztec functionalities.

Make sure strings will be translated:

geriux commented 8 months ago

Hey there @antonis 👋

I was wondering if you would be able to help me out with a PR review 😄, I've updated the Highlight color implementation so it fixes some issues for this feature since we first partially implemented it in https://github.com/wordpress-mobile/AztecEditor-Android/pull/943

A lot of testing has been already done in https://github.com/WordPress/gutenberg/pull/57650 so I was wondering if you'd have some time to check the native code for the Aztec side. Let me know if you could take a look! Thank you!

antonis commented 8 months ago

I was wondering if you'd have some time to check the native code for the Aztec side. Let me know if you could take a look! Thank you!

I'll be glad to help with this @geriux :) I plan to get to this later today or tomorrow 🙇

geriux commented 8 months ago

I'll be glad to help with this @geriux :) I plan to get to this later today or tomorrow 🙇

Thank you so much!

geriux commented 8 months ago

Thank you for all of the suggestions @antonis! I've applied them in https://github.com/wordpress-mobile/AztecEditor-Android/pull/1073/commits/17946f2be64e3177a4d1c52d98e53ac79985a1b2 and https://github.com/wordpress-mobile/AztecEditor-Android/pull/1073/commits/2f735642025c364e5a6003505f40d1ee93159237 🚀