Closed notandyvee closed 10 months ago
Looks like there are build issues. Will fix.
I tested and confirmed targetSdk upgrade works. 👍🏻
UI tests are failing because Robolectric added Android support with 4.11, and we are currently using 4.9. If you wish, you can upgrade the Robolectric version in a separate PR by targeting fix/target-sdk-34-update
to distinguish the context from this PR.
Done @irfano . Thanks!
Fix
Issue: #1072 Related: https://github.com/wordpress-mobile/gutenberg-mobile/issues/6533.
This PR bumps the
targetSdk
version from 33 to 34. It depends on WP Utils 141: https://github.com/wordpress-mobile/WordPress-Utils-Android/pull/141Test
Review
@irfano
Note
I'm not 100% sure how to test this against WP-util, other than waiting until that one is merged and then updating it here. Thoughts @ravishanker
Make sure strings will be translated:
strings.xml
as a part of the integration PR.