wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
673 stars 114 forks source link

[Fix] Update targetSdk to 34 from 33. #1074

Closed notandyvee closed 3 months ago

notandyvee commented 3 months ago

Fix

Issue: #1072 Related: https://github.com/wordpress-mobile/gutenberg-mobile/issues/6533.

This PR bumps the targetSdk version from 33 to 34. It depends on WP Utils 141: https://github.com/wordpress-mobile/WordPress-Utils-Android/pull/141

Test

Review

@irfano

Note

I'm not 100% sure how to test this against WP-util, other than waiting until that one is merged and then updating it here. Thoughts @ravishanker

Make sure strings will be translated:

notandyvee commented 3 months ago

Looks like there are build issues. Will fix.

irfano commented 3 months ago

I tested and confirmed targetSdk upgrade works. 👍🏻 UI tests are failing because Robolectric added Android support with 4.11, and we are currently using 4.9. If you wish, you can upgrade the Robolectric version in a separate PR by targeting fix/target-sdk-34-update to distinguish the context from this PR.

notandyvee commented 3 months ago

Done @irfano . Thanks!