Closed khaykov closed 4 months ago
With a help from Leak Canary I found a leak in EnhancedMovementMethod.
In this PR we are using weak reference for a click listener. Task list listener is not leaking, so it's ok to keep it as is.
aztec = Aztec.with(visualEditor, sourceEditor, toolbar, this) .... .setLinkTapEnabled(true) .setOnLinkTappedListener(object : AztecText.OnLinkTappedListener { override fun onLinkTapped(widget: View, url: String) { val intent = Intent(Intent.ACTION_VIEW) intent.data = Uri.parse(url) startActivity(intent) } }) ....
@[USER_NAME]
Make sure strings will be translated:
strings.xml
Fix
With a help from Leak Canary I found a leak in EnhancedMovementMethod.
In this PR we are using weak reference for a click listener. Task list listener is not leaking, so it's ok to keep it as is.
Test
Review
@[USER_NAME]
Make sure strings will be translated:
strings.xml
as a part of the integration PR.