Closed 0nko closed 7 years ago
I noticed a bit weird behavior:
Open hidden dialog with hidden html in demo app.
Add <b>
tags around "Menu", so the html will look like this:
<iframe class="classic"><b>Menu</b></iframe>
Press save, and open hidden tag again.
<b>
get's escaped, and html looks like this:
<iframe class="classic"><b>Menu</b></iframe>
Another minor issue is that the long code get's clipped at the bottom of the dialog:
Cursor related issue:
Open demo app. Go to source code, copy everything. Return to visual mode. Open Hidden html tag and replace "Menu" with copied code. Click save. Notice "aztec_cursor" appearing at the end of the editor.
At last, all of the issues should be fixed. Ready for another pass.
OK, now :P.
Thanks for the changes, everything works nicely now! I noticed only one minor thing - when there is a lot of content in dialog, the keyboard overlaps it, and bottom of dialog becomes hidden. It's especially noticeable in landscape mode.
Maybe setting soft input mode of dialog window to something like SOFT_INPUT_ADJUST_RESIZE
will help?
Thanks for the tip!
:shipit: 🎉
Adresses #167.
When you click on an unknown HTML question mark picture a dialog will pop up and you can edit the unknown HTML and save it.
I haven't made the unknown HTML a block span because that would create problems if it was embedded inside another block element and I don't see any issues as it is right now.