search

wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
675 stars 112 forks source link

Updated UI tests #479

Closed MatisseHack closed 6 years ago

MatisseHack commented 6 years ago

Test

  1. Run all tests in androidTest
0nko commented 6 years ago

When I run the unit tests, testMixedList() is failing because the expected value doesn't reflect the actual behavior. When you tap a single item in a list and change the list type, the entire list changes, which is the correct way.

MatisseHack commented 6 years ago

I was under the impression that only the list item(s) selected should change type. If the whole list should change, then that is inconsistent with iOS. Not sure which is correct, but it's an easy fix either way.

cc @aerych

aerych commented 6 years ago

Thanks @0nko. @MatisseHack if its no trouble could we update the test as @0nko described?

MatisseHack commented 6 years ago

No trouble at all

0nko commented 6 years ago

Thanks @MatisseHack! Looks good. I'll go ahead and merge this.

:shipit:

aerych commented 6 years ago

Thank you @0nko & @MatisseHack :)