search

wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
675 stars 112 forks source link

Updating gradle to 2.2.0 #84

Closed khaykov closed 7 years ago

khaykov commented 7 years ago

Bumping gradle version to 2.2.0

khaykov commented 7 years ago

Look like the the Robolectric doesn't work well with gradle 2.2.0 yet.

0nko commented 7 years ago

@khaykov, @theck13: Can you try it out? Seems to work for me.

theck13 commented 7 years ago

Travis still fails for me. It looks like a fix was released. Are you still running org.robolectric:robolectric:3.1 without issue?

0nko commented 7 years ago

I updated Robolectric to version 3.1.4 and it works on my machine. I just wanted to know if you can run tests locally. Travis fails because of this:

You have not accepted the license agreements of the following SDK components:
[Android SDK Platform 25, Android SDK Build-Tools 24.0.3].
theck13 commented 7 years ago

I can run tests locally.

Gradle is up to 2.2.3 now and it looks like it will be 2.3.0 soon according to Bintray.

0nko commented 7 years ago

Yup, I updated gradle, too. Thanks for checking.

0nko commented 7 years ago

So it seems the problem was that the compile SDK version was 25 but build tools version was 24. This is now fixed and ready to be merged.

theck13 commented 7 years ago

:shipit: