search

wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
675 stars 112 forks source link

Use org.wordpress:utils:1.30 to avoid com.android.support 27.1.1 conflict #929

Closed starshipcoder closed 2 years ago

starshipcoder commented 3 years ago

Update org.wordpress:utils to version 1.30.1 to avoid com.android.support 27.1.1 conflict

Need to update minSdkVersion to 18 because merging manifest failed due to org.wordpress:utils with minSdkVersion in 18

ygnessin commented 3 years ago

Seems like this would resolve my issue: https://github.com/wordpress-mobile/AztecEditor-Android/issues/933

Maintainers, could we please get a response about this? Thank you!

jd-alexander commented 3 years ago

Thanks for these changes @starshipcoder 🙇

Seems like this would resolve my issue: #933

thanks for pointing that out @ygnessin

I will be giving this a review and I will share my findings after.

ygnessin commented 3 years ago

Hi @jd-alexander I've opened a new PR #935 to replace this one. It updates the dependency to 1.30.1 without changing anything else.

Do you think you could take a look at it? Thank you!

jd-alexander commented 3 years ago

@ygnessin thanks much for the contribution and good question. it's best if you update the minSdk to 18. Once that's done and all the builds have passed you can let me know and I will give this another review.

ygnessin commented 3 years ago

Thanks for the reply @jd-alexander! This particular PR belongs to @starshipcoder, not me, and has already updated minSdk to 18. I'm not sure why the builds are failing but CI builds seem to be failing on all branches so maybe there's something wrong with the trunk branch?

oguzkocer commented 2 years ago

@starshipcoder Thank you for your contribution. I am sorry about the CI issue, it might have been an unrelated issue as suggested by @ygnessin. Regardless, we've made very similar changes in https://github.com/wordpress-mobile/AztecEditor-Android/pull/946 which hopefully addresses your issue. Please feel free to ping me if you have any further issues.