search

wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
681 stars 115 forks source link

Update wordpressUtilsVersion 1.21 -> 1.30.1 to fix AndroidX conflict #935

Closed yuvalgnessin-qz closed 2 years ago

yuvalgnessin-qz commented 3 years ago

Fix

This fixes #933 by resolving the dependency conflict with com.android.support 27.1.1

It also replaces #929 which seems to include unrelated changes, and which may have become stale

Review

@jd-alexander

yuvalgnessin-qz commented 3 years ago

Ah,I think I now understand why #929 bumped the minSdk version to 18. This error is coming from CI:

> Task :app:processDebugManifest FAILED
/home/circleci/project/app/src/main/AndroidManifest.xml Error:
    uses-sdk:minSdkVersion 16 cannot be smaller than version 18 declared in library [org.wordpress:utils:1.30.1] /home/circleci/.gradle/caches/transforms-1/files-1.1/utils-1.30.1.aar/1ba9ad2bd03c76473501b90da022cb57/AndroidManifest.xml as the library might be using APIs not available in 16
    Suggestion: use a compatible library with a minSdk of at most 16,
        or increase this project's minSdk version to at least 18,
        or use tools:overrideLibrary="org.wordpress.android.util" to force usage (may lead to runtime failures)

@jd-alexander Would you like me to use tools:overrideLibrary="org.wordpress.android.util" or to update the minSdk to 18?

oguzkocer commented 2 years ago

@yuvalgnessin-qz We've updated the WordPress-Utils-Android library to its latest version in https://github.com/wordpress-mobile/AztecEditor-Android/pull/946 and fixed #933. I am sorry that it took so long and this PR wasn't addressed before.