Closed planarvoid closed 2 years ago
thanks for the review @AmandaRiu ! the issue was caused by not adding \n
before the <hr>
when it was added as a block. This is necessary because otherwise the hr
is part either of the previous or the following block item. I'm still not 100% sure why the new h2
was created but adding the \n
fixes the issue (I've done that with the images before).
I forgot to push it @AmandaRiu 🤦
Fix
The media and the horizontal rule are currently added inline. For example you can add an image as a list item. In this PR I'm adding a setting where you can disable this behaviour. The new functionality adds a media item or a HR after the currently selected block. In addition to this when deleting text before an image (with backspace), the selection is moved so that you don't end up moving the image to become a part of the previous block.
Test 1
aztec.visualEditor.addMediaAfterBlocks()
in theMainActivity
Test 2
Test 3
Test 1
Test 4
Test 1
Review
@AmandaRiu
Make sure strings will be translated:
strings.xml
as a part of the integration PR.