wordpress-mobile / AztecEditor-Android

A reusable native Android rich text editor component.
Mozilla Public License 2.0
675 stars 112 forks source link

Release v1.5.6 #975

Closed planarvoid closed 2 years ago

planarvoid commented 2 years ago

This branch is used to test the changes made to Aztec editor in other repositories. It contains no changes to the logic, just the README update. To test it target: 975-e69dca965397a9f2978c8722976bee2f9de597ba as the aztec version.

Review

@AmandaRiu @hypest

Make sure strings will be translated:

hypest commented 2 years ago

Unfortunately, I won't have today to attend to this PR so, perhaps @mchowning you can join instead? @planarvoid also had let me know (via Slack) that this is ready to be tested from the gutenberg-mobile side and would like help with creating the gb-mobile and/or Gutenberg PRs to point to this one.

mchowning commented 2 years ago

I've created Gutenberg and Android PRs with this change. The WPAndroid PR has builds for testing. I did a bit of testing and didn't see any issues.

AmandaRiu commented 2 years ago

Will wait till this PR is merged before testing this PR. @planarvoid please let me know when it's ready 👍🏻

planarvoid commented 2 years ago

I think this is ready for review/merge @AmandaRiu @mchowning . The version number will actually be v1.5.7 but I'll add that tag only once this is merged. I've added the v1.5.6 tag too early and it doesn't include all the changes now.

AmandaRiu commented 2 years ago

This is approved, but unable to merge due to CI failures. Attempting to rerun.

AmandaRiu commented 2 years ago

Ah, the build is failing for CI on the step to publish to S3 because 1.5.6 is already published to S3. Going to do a forced merge.