search

wordpress-mobile / AztecEditor-iOS

A reusable native iOS visual HTML text editor component.
Mozilla Public License 2.0
612 stars 146 forks source link

Release 1.19.8 #1350

Closed twstokes closed 2 years ago

twstokes commented 2 years ago

The changes incorporated in the release 1.19.8 are:

twstokes commented 2 years ago

My plan is to merge this once the following PRs are approved:

I did a smoke test with Mobile Gutenberg pointed to the changes for https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1344 and it didn't appear affected. Running the Gutenberg Mobile demo and adding breakpoints here and here never paused execution when manipulating lists, telling me that Mobile Gutenberg doesn't use this path.

twstokes commented 2 years ago

@guarani would you mind taking a look at this release PR when convenient?

Thanks! 🙇

twstokes commented 2 years ago

I'm not familiar with the other change that's going into this release, but I presume it's also non-breaking, so can be shipped in a patch version.

Good thought: I think it qualifies for a patch in this case due to being a bugfix.

Do we need to create a WPiOS PR, point it to this branch, and have its CI checks pass to know that WPiOS also works? I'm not sure this is needed though.

Also a good thought. We'd tested the Headings bug independently, but I'll cut a branch to test this entire release just to be extra safe.

twstokes commented 2 years ago

I've created a PR in WPiOS to run CI for this release.