wordpress-mobile / AztecEditor-iOS

A reusable native iOS visual HTML text editor component.
Mozilla Public License 2.0
612 stars 146 forks source link

Use Xcode 15.0.1 #1377

Closed jkmassel closed 5 months ago

jkmassel commented 11 months ago

Migrates the project to Xcode 15 and Apple Silicon in CI

Also includes:

This can be reviewed by anyone, but I'd appreciate if @mokagio or @crazytonyli took a look at the project code adjustments!

Testing Details

Ensure CI passes


AliSoftware commented 9 months ago

Breadcrumbs: I reverted the attribution of the cluster to this repo in Buildkite (https://github.com/Automattic/buildkite-ci/pull/331) — aka reverted this repo to use Intel infra — while this PR is still not merged.

Once we land this PR, don't forget to redo the change in aztec-editor-ios.tf to switch it back to use the cluster again.

mokagio commented 8 months ago

I wanted to help here and tried to address the unit tests failures via https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1382 but didn't get very far.

mokagio commented 5 months ago

Going to merge this despite unit tests failures, to unblock moving to the cluster in CI, which in turns unblocks adopting the latest Xcode, https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1392, which, finally, will unblock https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1391.

I'm still experiencing unit tests issue locally, but I want to see how/if the situation changes once this lands.