Enable Dynamic Type for `RichText` within Gutenberg - Githubissues

wordpress-mobile / AztecEditor-iOS

A reusable native iOS visual HTML text editor component.

Mozilla Public License 2.0

611 stars 146 forks source link

Enable Dynamic Type for `RichText` within Gutenberg #1381

Closed SiobhyB closed 7 months ago

SiobhyB commented 7 months ago

Addresses https://github.com/wordpress-mobile/gutenberg-mobile/issues/4097

Related PRs

iOS: https://github.com/wordpress-mobile/WordPress-iOS/pull/22242
Gutenberg Mobile: https://github.com/wordpress-mobile/gutenberg-mobile/pull/6465

To Test

Open the Aztec demo app and play with different font sizes (via accessibility settings) to ensure there are no regressions.
Install the build available at https://github.com/wordpress-mobile/WordPress-iOS/pull/22242 and follow the testing instructions set out in that PR.

[ ] I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

SiobhyB commented 7 months ago

@twstokes, @geriux, I'd be grateful to hear your thoughts on this proposed solution for adding Dynamic Type support to Gutenberg. I've spent a lot of time experimenting, but this is my first time trying to get something to work in iOS' Aztec, so would be keen to hear your feedback. 🙇‍♀️

As I noted in https://github.com/wordpress-mobile/WordPress-iOS/pull/22242, the issue of some text appearing overly large when combined with custom font sizes (in block-based themes) will be addressed in a Gutenberg PR. That's an issue on both platforms as far as I can see, but we'd still need to add initial support in Aztec for iOS before addressing.