wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.96k stars 1.31k forks source link

Remote Preview operation and Progress Dialog management #10141

Open develric opened 5 years ago

develric commented 5 years ago

This is a draft issue to start tracking things

This is related to the work in PR #10085 (here the direct link to the conversation.).

From the PR review emerged the need to better investigate on the convenience to manage the progress dialog as cancelable but moreover to be able to conveniently cancel under certain circumstances (and correctly dismiss the dialog) the ongoing preview operation. Currently there is not an unique identified solution that fits both the EditPostActivity and the PostsListActivity with its VM. Some more analysis/discussion on this will be needed.

cc @maxme and @malinajirka

stale[bot] commented 4 years ago

This issue has been marked as stale because:

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

develric commented 4 years ago

This was a case at the time it was written but I think we actually changed strategy (moving away from the dialog?) in the more recent implementation. If this is right this is outdated and can be closed.

cc @malinajirka for a confirmation on the current implementation in case I'm missing anything, thanks 🙇‍♂️

malinajirka commented 4 years ago

I believe this is not outdated. AFAICT we are still using non-cancelable dialog - dialog states and example usage. Wdyt?

develric commented 4 years ago

Just leaving a quick comment here to say that on the 27 July week I will be in Grounds Keeping and will take care to further check this.

dangermattic commented 2 months ago

Thanks for reporting! 👍