Open develric opened 5 years ago
This issue has been marked as stale because:
[Pri] Blocker
, [Pri] High
, or good first issue
.Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).
This was a case at the time it was written but I think we actually changed strategy (moving away from the dialog?) in the more recent implementation. If this is right this is outdated and can be closed.
cc @malinajirka for a confirmation on the current implementation in case I'm missing anything, thanks 🙇♂️
I believe this is not outdated. AFAICT we are still using non-cancelable
dialog - dialog states and example usage. Wdyt?
Just leaving a quick comment here to say that on the 27 July week I will be in Grounds Keeping and will take care to further check this.
Thanks for reporting! 👍
This is a draft issue to start tracking things
This is related to the work in PR #10085 (here the direct link to the conversation.).
From the PR review emerged the need to better investigate on the convenience to manage the progress dialog as cancelable but moreover to be able to conveniently cancel under certain circumstances (and correctly dismiss the dialog) the ongoing preview operation. Currently there is not an unique identified solution that fits both the EditPostActivity and the PostsListActivity with its VM. Some more analysis/discussion on this will be needed.
cc @maxme and @malinajirka