wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.96k stars 1.31k forks source link

Some login dialogs are not styled correctly in Dark Mode #11650

Open khaykov opened 4 years ago

khaykov commented 4 years ago

“Continue with” screen on the email sign-in flow and “Choose an account” screen in the Google sign-in flow are not styled correctly in Dark Mode.

We need to investigate how much control we have over them and change their style to match Dark Theme if possible.

renanferrari commented 4 years ago

After some investigation, I unfortunately have not found a way of styling those dialogs with dark mode. Here's what I tried:

After some benchmarking I realized other apps that use this library are facing the exact same issue, so at least it's not something our users would only see in our app. I think there's nothing we can do at the moment, unless waiting for a library update that would introduce an official way of handling this.