search

wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.98k stars 1.33k forks source link

Including a button to browse the files from the device in the Media Picker. #12854

Open develric opened 4 years ago

develric commented 4 years ago

Even with the upcoming Media Picker Consolidation project we should still include a button to browse the files on the device.

We can place it in the right-hand position on the top appbar of the picker using the gridicons-image.svg icon for this since this matches with what can be found currently for selecting an image from the device.

designsimply commented 4 years ago

Do you have a design file you could include with this issue?

Here are some current screenshots of the media picker in the Media and Editor screens taken with 15.6 beta:

Self-hosted Media Self-hosted Editor Jetpack Media Jetpack Editor Media > Choose from device Editor > Choose from device
Screenshot_20200903-130016 Screenshot_20200903-130037 Screenshot_20200903-125536 Screenshot_20200903-125612 Screenshot_20200903-131225 Screenshot_20200903-131332

Tested with WPAndroid 15.6-rc-2 on Pixel 3 Android 10 on sites running WordPress 5.5.1 Jetpack 8.9.

develric commented 4 years ago

Hey @designsimply thanks for the above 🙇‍♂️; I started opening a PR #12884 related to this hopefully to ease some discussion about it. We are thinkering with @planarvoid already a bit and we will soon ping @SylvesterWilmott to have his input design wise (currently we have this comment thread that triggered the task pbArwn-nS-p2#comment-1556)