wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.95k stars 1.31k forks source link

Site Settings Screen - No Network check #15590

Open AjeshRPai opened 2 years ago

AjeshRPai commented 2 years ago

In My Site -> Site Settings. The Internet connection is checked in order to enable the settings in the Screen.

When Internet Available(Editing Enabled) No Internet (Editing Disabled)
Screenshot_20211118-193439 Screenshot_20211118-193442

Suppose internet is available and user goes to Tags screen. If the internet is not available after navigating back to the site settings screen, then the user is able to edit the settings offline which is not handled on TimeZone/Add tag.

PFB the recording which shows the Issue.

carl-duncan commented 2 years ago

https://github.com/wordpress-mobile/WordPress-Android/pull/16737

carl-duncan commented 2 years ago

Hey I resolved this issue @AjeshRPai .