search

wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.96k stars 1.31k forks source link

The template previews are off to the right when choosing a site design in RTL languages #16456

Open ovitrif opened 2 years ago

ovitrif commented 2 years ago

Expected behavior

The templates preview thumbnails are centered for all languages.

Actual behavior

The templates preview thumbnails are not centered for RTL languages.

Steps to reproduce the behavior

  1. Set the application language to Hebrew or Arabic
  2. Start the site creation flow
  3. Navigate till you are on the step to choose the template / design / theme
  4. Notice that the templates preview thumbnails are aligned to the right.

Previews

English Hebrew Arabic
english hebrew arabic
Tested on Samsung Galaxy S8+, Android 9, WPAndroid 19.7

Discovered while testing #16428

antonis commented 2 years ago

The issue is still reproduced in the new design. Screenshot_20220526_171255 We could initially focus on the client side and the category titles alignment. The mShots issue can be handled separately on the server.

carl-duncan commented 2 years ago

Hello, I will fix this issue.

antonis commented 2 years ago

Hello, I will fix this issue.

Thank you for stepping forward with this (too) @carl-duncan 🙇 Let us know if we can help. We'll be happy to review your PR 🥇

carl-duncan commented 2 years ago

Confirmed the issue is with the library MShots , fixed the title alignment while that is resolved however: https://github.com/wordpress-mobile/WordPress-Android/pull/16673