wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.96k stars 1.31k forks source link

Blogging Reminders are not received until the following week #16596

Open guarani opened 2 years ago

guarani commented 2 years ago

Expected behavior

After setting a Blogging Reminder to a time a few minutes in the future, I expect to get a reminder after those few minutes have elapsed.

Actual behavior

I don't get a reminder after five minutes.

Steps to reproduce the behavior

  1. Open the app to manage a site
  2. (For easier testing) ensure the site timezone is set to your local timezone
  3. Go to My Site tab → Menu tab → Blogging Reminders
  4. Schedule a blogging reminder for the current day, a few minutes in the future
  5. Wait five minutes
  6. Check the system-wide notification screen and notice no notification was received
Tested on Samsung Galaxy S10, Android 12, WPAndroid 19.8

Additional context

guarani commented 2 years ago

Blogging Reminders on Android was implemented so that the reminder will arrive on the chosen day, but on the following week. Here are some examples:

  • If all days are selected, it will fire everyday from tomorrow onward.
  • If today is Wednesday and only Friday is selected, it won't fire the-day-after-tomorrow but instead on Friday of next week.

It looks like the above information is inaccurate. On Wednesday night I scheduled a notification for Thursdays and Fridays at 10:00. I checked the phone Thursday and the notification fired at 10:10, as it should (update: Friday's notification also fired 👍). I've updated the issue description to reflect this new information.

Given this new information, I think it would still be good to change the behavior to fire any reminder that's set for a future date/time, even if that is the current day. However, that seems less of a bug, so I'll change the priority to Low.

guarani commented 2 years ago

On a slightly different topic, when I set Blogging Reminder notifications for 10:00, the notifications arrive at different times (I saw one at 10:10 and another at 10:33). I think this is out of the scope of this issue, but I don't think it's important enough yet to create a second issue.