Options
(1) Handle this on the clients before/after scanning. The QR code login flow is not required to start within the app; the device camera or a scanning app can start the flow.
two_step_enabled is part of AccountSettings and does not exist in the AccountModel. FluxC changes are required to add this information to the AccountModel.
The check for 2FA disabled can be made after "Scan Login Code" is tapped on the Me menu (before it goes into scanning mode). Show an error toast.
If the QR code is scanned from the camera, not Me -> Scan Login Code, the user gets dumped into the scan flow and will see an error message. We'll need to adjust the error message about 2FA
OR
(2) Enhance the endpoint and return a new error code to indicate that 2FA is not enabled. Use this code to show an explicit "2FA" error message after scanning (the error view already exists)
OR
(3) An authentication error view is currently show in the QR login flow when auth fails. Update the web site to include a message that 2FA enabled accounts are not eligible to use the qr code login process. This messaging can be added to the "Login via the mobile app" view. This option requires no client changes.
dangermattic
commented
4 months ago
QR Login isn't available for accounts with 2FA. It would be nice if we could detect if 2FA is enabled and warn the user.
Options (1) Handle this on the clients before/after scanning. The QR code login flow is not required to start within the app; the device camera or a scanning app can start the flow.
two_step_enabledis part of AccountSettings and does not exist in the AccountModel. FluxC changes are required to add this information to the AccountModel.OR (2) Enhance the endpoint and return a new error code to indicate that 2FA is not enabled. Use this code to show an explicit "2FA" error message after scanning (the error view already exists)
OR (3) An authentication error view is currently show in the QR login flow when auth fails. Update the web site to include a message that 2FA enabled accounts are not eligible to use the qr code login process. This messaging can be added to the "Login via the mobile app" view. This option requires no client changes.