Closed ParaskP7 closed 10 months ago
Fails | |
---|---|
:no_entry_sign: | Please add a type label to this issue. e.g. '[Type] Enhancement' |
Generated by :no_entry_sign: dangerJS
Fails | |
---|---|
:no_entry_sign: | Please add a type label to this issue. e.g. '[Type] Enhancement' |
Generated by :no_entry_sign: dangerJS
Fails | |
---|---|
:no_entry_sign: | Please add a type label to this issue. e.g. '[Type] Enhancement' |
Generated by :no_entry_sign: dangerJS
✅ The latest stable version of apacheCommonsTextVersion
is 1.10.0
(see releases). As such, this item is now marked as complete.
✅ The latest stable version of glassfishJavaxAnnotationVersion
is 10.0-b28
(see mvn repository). As such, this item is now marked as complete.
(❓) Actually, I tried removing this glassfishJavaxAnnotationVersion
and its compile only usage (compileOnly "org.glassfish:javax.annotation:$glassfishJavaxAnnotationVersion"
) from the project, but the compilation failed with the below errors:
Looking at the first instance of the failure and ApplicationModule_ContributeStatListFragment
I noticed that removing this dependency and rebuilding the project is also removing the import javax.annotation.Generated;
import and its @Generated("dagger.android.processor.AndroidProcessor")
class annotation usage from that Dagger generated application module class. Then, just because of that the build fails with Hilt complaining about: 🔍
[Hilt] Processing did not complete. See error above for details.
WCAndroid is not using such a dependency and I wonder if WPAndroid could avoid using it and thus remove it somehow. We might want to try and figure out how to configure Hilt so that it doesn't complain on it. 🤔
Cc @irfano being the Hilt master of the WPAndroid multiverse, maybe you can think of something! 🥇
✅ The latest stable version of
glassfishJavaxAnnotationVersion
is10.0-b28
(see mvn repository). As such, this item is now marked as complete.(❓) Actually, I tried removing this
glassfishJavaxAnnotationVersion
and its compile only usage (compileOnly "org.glassfish:javax.annotation:$glassfishJavaxAnnotationVersion"
) from the project, but the compilation failed with the below errors:🚫 Build Failure Looking at the first instance of the failure and
ApplicationModule_ContributeStatListFragment
I noticed that removing this dependency and rebuilding the project is also removing theimport javax.annotation.Generated;
import and its@Generated("dagger.android.processor.AndroidProcessor")
class annotation usage from that Dagger generated application module class. Then, just because of that the build fails with Hilt complaining about: 🔍
[Hilt] Processing did not complete. See error above for details.
WCAndroid is not using such a dependency and I wonder if WPAndroid could avoid using it and thus remove it somehow. We might want to try and figure out how to configure Hilt so that it doesn't complain on it. 🤔
Cc @irfano being the Hilt master of the WPAndroid multiverse, maybe you can think of something! 🥇
I'm sorry for the significant delay in my response, @ParaskP7. Somehow, I missed the notification for your comment.
I opened a PR to migrate some views causing the error to the Hilt.
Now we can remove compileOnly "org.glassfish:javax.annotation:$glassfishJavaxAnnotationVersion"
👋 @irfano and awesome, thank you a lot for your response and for looking into this!
I opened a https://github.com/wordpress-mobile/WordPress-Android/pull/18158 to migrate some views causing the error to the Hilt. Now we can remove compileOnly "org.glassfish:javax.annotation:$glassfishJavaxAnnotationVersion"
This is great, I'll take a look at the PR your opened as soon as possible! 🥇
Suggestion (💡): Let's also remove this org.glassfish:javax.annotation:$glassfishJavaxAnnotationVersion
as part of this PR and test this thing once, wdyt? 🤔
The only dependency that hasn't been dealt with is squareupKotlinPoetVersion
. This dependency should be now handled as part of our now standard Dependabot process.
Parent #17551
🚫 Blocked By (for
KotlinPoet
):KotlinPoet
to1.12.0
addsKotlin 1.7.0
as a transitive dependency to the project. It is better to do theKotlin
update explicitly rather than implicitly.This issue is about updating all
Main - Other Core
related dependencies for the whole project.This
Main - Other Core
batch contains the following5
dependencies:apacheCommonsTextVersion = '1.10.0'
(see releases) -> CommentglassfishJavaxAnnotationVersion = '10.0-b28'
(see mvn repository) -> Comment with Call to Action (❓)googleAutoServiceVersion = '1.0'
(see releases, look forAutoService
) -> #18076squareupKotlinPoetVersion = '1.6.0'
(see releases)