search

wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Nullability Annotations to Java Classes - ViewHolder #19192

Open ParaskP7 opened 1 year ago

ParaskP7 commented 1 year ago

Parent #18912

This issue is about adding missing nullability annotations (@Nullable & @NonNull) to as many recycler view holder only Java-related classes as possible, including fields, arguments, parameters, and return values.

### Tasks (`inner` + `fragment`)
- [ ] [LoginFooterViewHolder.java](https://github.com/wordpress-mobile/WordPress-Android/blob/1b38e8c84f8e8b30626406fd0568beeffd8f7676/WordPress/src/main/java/org/wordpress/android/ui/accounts/login/LoginFooterViewHolder.java#L4) <- [SitePickerAdapter.java](https://github.com/wordpress-mobile/WordPress-Android/blob/1b38e8c84f8e8b30626406fd0568beeffd8f7676/WordPress/src/main/java/org/wordpress/android/ui/main/SitePickerAdapter.java#L4)
- [ ] [LoginHeaderViewHolder.java](https://github.com/wordpress-mobile/WordPress-Android/blob/1b38e8c84f8e8b30626406fd0568beeffd8f7676/WordPress/src/main/java/org/wordpress/android/ui/accounts/login/LoginHeaderViewHolder.java#L4) <- [SitePickerAdapter.java](https://github.com/wordpress-mobile/WordPress-Android/blob/1b38e8c84f8e8b30626406fd0568beeffd8f7676/WordPress/src/main/java/org/wordpress/android/ui/main/SitePickerAdapter.java#L4)
### Tasks (`inner` + `fragment`)
- [ ] [ShareIntentReceiverFragment.java](https://github.com/wordpress-mobile/WordPress-Android/blob/1b38e8c84f8e8b30626406fd0568beeffd8f7676/WordPress/src/main/java/org/wordpress/android/ui/ShareIntentReceiverFragment.java#L4) -> [HeaderViewHolder](https://github.com/wordpress-mobile/WordPress-Android/blob/1b38e8c84f8e8b30626406fd0568beeffd8f7676/WordPress/src/main/java/org/wordpress/android/ui/ShareIntentReceiverFragment.java#L200-L211)
- [ ] [StockMediaPickerActivity.java](https://github.com/wordpress-mobile/WordPress-Android/blob/1b38e8c84f8e8b30626406fd0568beeffd8f7676/WordPress/src/main/java/org/wordpress/android/ui/stockmedia/StockMediaPickerActivity.java#L4) -> [StockViewHolder](https://github.com/wordpress-mobile/WordPress-Android/blob/1b38e8c84f8e8b30626406fd0568beeffd8f7676/WordPress/src/main/java/org/wordpress/android/ui/stockmedia/StockMediaPickerActivity.java#L753-L788)
peril-wordpress-mobile[bot] commented 1 year ago
Fails
:no_entry_sign: Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by :no_entry_sign: dangerJS