wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.95k stars 1.31k forks source link

[Reader Improvements] Fix follow tag responsiveness on "Manage Topics & Sites" screen #19534

Open RenanLukas opened 9 months ago

RenanLukas commented 9 months ago

When user taps to add a new tag on "Manage Topics & Sites" ("Followed Topics" tab) it takes a while to update the tags list. This happens because we wait for the network response and also the local DB update before updating the UI.

We should update the UI immediately after the the user taps on the add button and if the network request fails we show the previous status.

daniloercoli commented 5 months ago

I think we can close this issue, since it was already fixed.

RenanLukas commented 5 months ago

@daniloercoli by the look of the UI it seems to me that we're still waiting for the network response to update the tags list. Here's an example with bad network:

https://github.com/wordpress-mobile/WordPress-Android/assets/14964993/7d17a264-74a3-433c-b1cb-c1e5b8192ed0

Since the proposal of the issue is to immediately update the RecyclerView (without waiting for the request) and in case the request fails show the previous state (and also maybe an error toast/snackbar) maybe we should keep it open or close it as "won't do"/"not planned". WDYT?

daniloercoli commented 5 months ago

Oh sorry, I misinterpreted the title. We can keep it open but will move it outside the scope of the next sprint, as we want to focus on bug fixes.

dangermattic commented 1 month ago

Thanks for reporting! 👍