search

wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.96k stars 1.31k forks source link

[Reader] Replace "Fetching posts" with skeleton/shimmer #19545

Open thomashorta opened 10 months ago

thomashorta commented 10 months ago

Future idea would be to replace the "Fetching posts" text when there are no posts with a skeleton/shimmer state as we do in other places.

Originally posted by @osullivanchris in https://github.com/wordpress-mobile/WordPress-Android/pull/19495#pullrequestreview-1712364112

antonis commented 7 months ago

I've noticed a minor UI bug that occurs when the reader refreshes while there is cached content displayed. In this occasion the "Fetching posts" overlaps with the content as seen on the screenshot below.

Since replacing the label is already on the backlog I thought of adding a note here. Let me know if I should create a separate bug report 🙇

thomashorta commented 7 months ago

@antonis thanks for the report, could you go ahead and open a ticket? We were aware of the problem but were not sure about the exact scenario and it looks like we don't have a GH issue, so it would be great if you could create one and add the steps and screenshot above.

I am not sure when we will get to adding the skeleton/shimmer while loading, so it's better to have a separate issue in case we can fix the overlap in the mean time.

Thanks!

antonis commented 7 months ago

Makes sense @thomashorta 👍

We were aware of the problem but were not sure about the exact scenario and it looks like we don't have a GH issue

I wasn't able to replicate it today. I'll keep an eye on this and iterate back with an issue with detailed steps.