wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

[Reader] Use `"follow"` for tag strings instead of `"subscribe"` #20513

Closed RenanLukas closed 1 month ago

RenanLukas commented 1 month ago

Fixes #20297


To Test:

  1. Launch Jetpack and login
  2. Do a general smoke test of Reader screens
  3. All tag related strings should be using "follow" instead of "subscribe"

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    --


PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 1 month ago
2 Warnings
:warning: strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20513-2f338af
Commit2f338af54b522bbc62523ff92d7110127dacbe56
Direct Downloadjetpack-prototype-build-pr20513-2f338af.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20513-2f338af
Commit2f338af54b522bbc62523ff92d7110127dacbe56
Direct Downloadwordpress-prototype-build-pr20513-2f338af.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.43%. Comparing base (1f319a4) to head (2f338af).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #20513 +/- ## ======================================= Coverage 40.43% 40.43% ======================================= Files 1463 1463 Lines 67305 67305 Branches 11186 11186 ======================================= Hits 27218 27218 Misses 37611 37611 Partials 2476 2476 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.