Fixes broken notification comments regression

antonis commented 1 month ago

Fixes broken notification comments (see p1711097822404029-slack-C0180B5PRJ4)

Description

This PR fixes a regression introduced by https://github.com/wordpress-mobile/WordPress-Android/pull/20452 were the notification comments did not appear

Verify that notification comments appear
Verify that the confetti is shown (see https://github.com/wordpress-mobile/WordPress-Android/pull/20452)

Potential unintended areas of impact
- Notifications
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing
What automated tests I added (or what prevented me from doing so)
- This part of the code is not easy to test without a major refactoring that would escape the scope of this PR

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 1 month ago

	1 Warning
:warning:	This PR is assigned to the milestone 24.5 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20522-2a7e26f
	Commit	2a7e26f25ef36e357f39e703026cfcf46fe9d133
	Direct Download	`wordpress-prototype-build-pr20522-2a7e26f.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20522-2a7e26f
	Commit	2a7e26f25ef36e357f39e703026cfcf46fe9d133
	Direct Download	`jetpack-prototype-build-pr20522-2a7e26f.apk`

Note: Google Login is not supported on these builds.

antonis commented 1 month ago

Thank you for the prompt review @jarvislin 🙇