Fix pull to refresh Stats bug

aditi-bhatia commented 1 month ago

Fixes https://github.com/wordpress-mobile/WordPress-Android/issues/20397

This PR fixes an issue where pull to refresh wouldn't update Stats. This was happening because statsSection was being set to TRAFFIC with no information on time granularity. This PR maps StatsGranularity to its corresponding StatsSection so that we can refresh the correct useCase. For example, it maps StatsGranularity.DAYS to StatsSection.DAYS so the correct data can be refreshed. Alternatively, we could choose to refresh all granularities on pull to refresh which would remove the need for mapping with the feature flag on, but would also be less efficient.

To Test:

With the Stats feature flag on, navigate to the Stats page.
Turn data off and change the granularity or time period.
You should see There was a problem loading your data, refresh your page to try again:
Turn data on again. Refresh the page and it should display data.
Repeat steps 1-4 with the feature flag off.

Regression Notes

Potential unintended areas of impact
- None
What I did to test those areas of impact (or what existing automated tests I relied on)
- None
What automated tests I added (or what prevented me from doing so)
- None

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20524-2d30d0b
	Commit	2d30d0b8f44ec4ad724ed8bc5efe52f42ea168e3
	Direct Download	`jetpack-prototype-build-pr20524-2d30d0b.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20524-2d30d0b
	Commit	2d30d0b8f44ec4ad724ed8bc5efe52f42ea168e3
	Direct Download	`wordpress-prototype-build-pr20524-2d30d0b.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 40.43%. Comparing base (27ad674) to head (2d30d0b). Report is 484 commits behind head on trunk.

Files	Patch %	Lines
...rdpress/android/ui/stats/refresh/StatsViewModel.kt	0.00%	14 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #20524 +/- ## ========================================== - Coverage 40.43% 40.43% -0.01% ========================================== Files 1463 1463 Lines 67301 67312 +11 Branches 11186 11190 +4 ========================================== Hits 27216 27216 - Misses 37609 37620 +11 Partials 2476 2476 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dangermattic commented 4 weeks ago

	1 Warning
:warning:	PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wordpress-mobile / WordPress-Android