wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

[Reader] Fix like button responsiveness in "Discover" feed #20525

Closed RenanLukas closed 1 month ago

RenanLukas commented 1 month ago

Fixes #19533


To Test:

  1. Install JP and sign in.
  2. Open Reader and select "Discover".
  3. πŸ” Like a post with internet connection available: it should work as expected.
  4. πŸ” Tap the like button again to remove the like with internet connection available: it should work as expected.
  5. πŸ” Repeat steps 3 and 4 with no internet connection (e.g. airplane mode) and bad internet connection (e.g. 100% loss on Network Link Conditioner). If there's no connection, the like button state shouldn't change and if there's bad network connection the button should change right away and then when the request fails return to the previous state.

Regression Notes

  1. Potential unintended areas of impact

    • Reader post list like button
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    --


PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 1 month ago
1 Warning
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
WordPressπŸ“² You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20525-4d9fb5e
Commit4d9fb5e60eacb5ca3e52b7f725282e2a6ae75771
Direct Downloadwordpress-prototype-build-pr20525-4d9fb5e.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
JetpackπŸ“² You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20525-4d9fb5e
Commit4d9fb5e60eacb5ca3e52b7f725282e2a6ae75771
Direct Downloadjetpack-prototype-build-pr20525-4d9fb5e.apk
Note: Google Login is not supported on these builds.