wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Fix open traffic tab from today's stats card #20526

Closed irfano closed 1 month ago

irfano commented 1 month ago

Fixes #20487

This updates Today's Stats card to have it open "By day" granularity.


To Test:

Test this with both the stats_traffic_tab enabled and disabled cases:

  1. Open "My Site → Stats"
  2. Change granularity to something different from "Day".
  3. Tap on the "Today's Stats" card from My Site.
  4. Verify that it opens the Day granularity in Stats.

Regression Notes

  1. Potential unintended areas of impact

    • Opening Stats from other entry points.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Tested manually.
  3. What automated tests I added (or what prevented me from doing so)

    • Updated current tests.

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20526-7cbb4fb
Commit7cbb4fbb49d34771c1e5c543ad61341160834333
Direct Downloadjetpack-prototype-build-pr20526-7cbb4fb.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20526-7cbb4fb
Commit7cbb4fbb49d34771c1e5c543ad61341160834333
Direct Downloadwordpress-prototype-build-pr20526-7cbb4fb.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 40.24%. Comparing base (93d9440) to head (7cbb4fb).

Files Patch % Lines
...rdpress/android/ui/stats/refresh/StatsViewModel.kt 50.00% 1 Missing and 2 partials :warning:
...d/ui/stats/refresh/utils/SelectedSectionManager.kt 0.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #20526 +/- ## ======================================= Coverage 40.24% 40.24% ======================================= Files 1462 1462 Lines 67592 67592 Branches 11200 11200 ======================================= + Hits 27201 27204 +3 + Misses 37931 37927 -4 - Partials 2460 2461 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.