Adds Webview version in Sentry crash logging

antonis commented 1 month ago

Description

This PR adds the Webview version in Sentry crash logging to better monitor issues like https://github.com/wordpress-mobile/WordPress-Android/issues/20147

Notes

I initially considered adding the version in the extras https://github.com/wordpress-mobile/WordPress-Android/pull/20533/commits/4ba20a721dec802fc7b34a97b77d7d9e7a942e09. This worked (example) but additional data are not searchable/filterable making the added data less valuable. I switched to using a tag by using the applicationContextProvider that exposes it's data as tags. Another alternative would be to add a new dedicated field in the CrashLoggingDataProvider. Since this might not be valuable for other apps and to keep the enhancement simpler I didn't choose this path.

To Test:

Run a build from this PR
Trigger a crash (you could apply this patch and tap on the Posts menu option)
Check Sentry and verify that the crash is received containing the webview.version tag (example)

Regression Notes

Potential unintended areas of impact
- Sentry logging
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing
What automated tests I added (or what prevented me from doing so)
- Updated existing test cases

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20533-fb90630
	Commit	fb90630f67e9a98b7bece9d542796fb430b809a1
	Direct Download	`jetpack-prototype-build-pr20533-fb90630.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20533-fb90630
	Commit	fb90630f67e9a98b7bece9d542796fb430b809a1
	Direct Download	`wordpress-prototype-build-pr20533-fb90630.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 40.24%. Comparing base (7ff5847) to head (fb90630).

Files	Patch %	Lines
...ndroid/util/crashlogging/WebviewVersionProvider.kt	0.00%	7 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #20533 +/- ## ========================================== - Coverage 40.24% 40.24% -0.01% ========================================== Files 1462 1463 +1 Lines 67592 67600 +8 Branches 11200 11201 +1 ========================================== + Hits 27204 27205 +1 - Misses 37927 37934 +7 Partials 2461 2461 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

antonis commented 1 month ago

Hey @wzieba 👋 I've added you as a reviewer on this PR since you might have a better understanding of the crash logging implementation in https://github.com/Automattic/Automattic-Tracks-Android. If you have the time any feedback is more than welcome 🙇

antonis commented 1 month ago

Thank you for the prompt review and feedback @wzieba 🙇